Some comments inline... On Thu, Nov 12, 2015 at 10:37 AM, Jesse Glick <[email protected]> wrote:
> On Wed, Nov 11, 2015 at 6:22 PM, Owen B. Mehegan <[email protected]> > wrote: > > I can't figure out how to access the branch parameters that the > > plugin is setting. If you look at the 'Using it with a job' section of > the > > readme, it has you configure Git to expect variables like > gitlabSourceBranch > > and gitlabTargetBranch to be set when a build is triggered by Gitlab. > > Two things. > > First of all, the code in `onPost` is wrong. See > > https://github.com/jenkinsci/workflow-plugin/blob/master/COMPATIBILITY.md > > for background but basically you need to be using > `ParameterizedJobMixIn`, which allows `actions` to be passed to any > build you schedule. There is no need to check for `instanceof > AbstractProject`. > OK, I'll look at refactoring this. Second, the whole system the plugin is using to specify a branch per > build can be considered obsolete. Instead, depend on `scm-api`, > implement `SCMSource`, and use multibranch workflows (or other > multibranch projects). See `github-branch-source` for an example. > I think I get what you're saying: that the plugin should move toward the multibranch project model, rather than one job which takes a parameter of branch (and whose current "status" is therefore usually meaningless). I'm open to that idea but I suspect it will be more work to implement. I'll consider it part of the roadmap for this plugin. -- > You received this message because you are subscribed to a topic in the > Google Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/CJEbh85zRx8/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2y9oMS6T7Maje_VahF7qp5LqoFv0JaTZ7zFYdO-_1hyg%40mail.gmail.com > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAHtcACGtDiMCHx4mzjRS2Ma9gaw0%3D1WcnScB-a7AJ6ifBkYAxQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
