Hi guys, after some trouble with the complexity of the plugin I finally managed it to create a PR which integrates the Job DSL extension directly into the promoted-builds-plugin: https://github.com/jenkinsci/promoted-builds-plugin/pull/81
It would be great if Oleg could review the PR and merge the code to create a new release of the plugin :-) Thanks in advance Dennis Am Mittwoch, 13. Januar 2016 19:33:28 UTC+1 schrieb Dennis Schulte: > > Hello, I'm actually working on it. The first step was the migration of the > Job DSL Promotions Plugin to Java (see > https://github.com/codecentric/job-dsl-promotions-plugin). In the next > days I will create a PR for the Promoted Builds Plugin.... > > Best Regards > Dennis > > Am Mittwoch, 13. Januar 2016 16:39:44 UTC+1 schrieb Ferenc Kovacs: >> >> hi, >> >> any update on this? (sorry all of the open jira issues about the jobdsl >> <-> promoted builds integration seems to have way less activity than this >> thread.) >> >> On Friday, October 2, 2015 at 3:14:20 PM UTC+2, Oleg Nenashev wrote: >>> >>> Just to clarify... >>> As a maintainer of promoted-builds-plugin, I'm OK with an *optional* >>> dependency. >>> There is already a dependency on the token-macro with a similar security >>> flaw, so I don't see any practical reason to keep the integration code in a >>> separate plugin if it is tested enough. >>> >>> среда, 30 сентября 2015 г., 2:01:16 UTC+3 пользователь Kanstantsin >>> Shautsou написал: >>>> >>>> Statement is right, but has no any clarification rather then “must >>>> die". Jenkins already supports loading plugins and allows doing optional >>>> dependencies. >>>> Could you provide any real reason to not use optional dependency in >>>> this case? >>>> >>>> On Sep 30, 2015, at 01:46, Stephen Connolly <stephen.al...@gmail.com> >>>> wrote: >>>> >>>> Java dependencies are not the same as Linux package dependencies >>>> >>>> On Tuesday 29 September 2015, Kanstantsin Shautsou < >>>> kanstan...@gmail.com> wrote: >>>> >>>>> Optional dependencies works fine for many years in linux distros. What >>>>> is the problem in jenkins? >>>>> Redundant hard deps should also die. >>>>> >>>>> PS bottom-quote on top-quote is bad manner. >>>>> > On Sep 29, 2015, at 18:21, Stephen Connolly < >>>>> stephen.alan.conno...@gmail.com> wrote: >>>>> > >>>>> > to quote Jesse: "optional dependencies must die" >>>>> > >>>>> > On 29 September 2015 at 13:47, Daniel Beck <m...@beckweb.net> wrote: >>>>> >> >>>>> >> On 29.09.2015, at 14:20, Stephen Connolly < >>>>> stephen.alan.conno...@gmail.com> wrote: >>>>> >> >>>>> >>> Please do not add a dependency on job-DSL to promoted-builds (at >>>>> least until job-dsl has fixed the security design issues) >>>>> >> >>>>> >> Wouldn't that dependency be optional anyway? >>>>> >> >>>>> >> -- >>>>> >> You received this message because you are subscribed to the Google >>>>> Groups "Jenkins Developers" group. >>>>> >> To unsubscribe from this group and stop receiving emails from it, >>>>> send an email to jenkinsci-dev+unsubscr...@googlegroups.com. >>>>> >> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-dev/F102D219-20B7-47A2-9882-DEAA572D6DB8%40beckweb.net >>>>> . >>>>> >> For more options, visit https://groups.google.com/d/optout. >>>>> > >>>>> > -- >>>>> > You received this message because you are subscribed to a topic in >>>>> the Google Groups "Jenkins Developers" group. >>>>> > To unsubscribe from this topic, visit >>>>> https://groups.google.com/d/topic/jenkinsci-dev/IZ3kBFhIYYg/unsubscribe >>>>> . >>>>> > To unsubscribe from this group and all its topics, send an email to >>>>> jenkinsci-dev+unsubscr...@googlegroups.com. >>>>> > To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMwq%3Dvis9A8PsKzVvxwQEDUuEbhNzHfEkwnqU_7YXgNHFw%40mail.gmail.com >>>>> . >>>>> > For more options, visit https://groups.google.com/d/optout. >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Jenkins Developers" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to jenkinsci-dev+unsubscr...@googlegroups.com. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-dev/B88B0980-815D-468F-9823-788F4DD8C7FE%40gmail.com >>>>> . >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> >>>> -- >>>> Sent from my phone >>>> >>>> -- >>>> You received this message because you are subscribed to a topic in the >>>> Google Groups "Jenkins Developers" group. >>>> To unsubscribe from this topic, visit >>>> https://groups.google.com/d/topic/jenkinsci-dev/IZ3kBFhIYYg/unsubscribe >>>> . >>>> To unsubscribe from this group and all its topics, send an email to >>>> jenkinsci-de...@googlegroups.com. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxXb_BrU3%3DdsR97mQ-5TEQ8%2B8ox0VrwAV%2BKZgSdSpVQcg%40mail.gmail.com >>>> >>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxXb_BrU3%3DdsR97mQ-5TEQ8%2B8ox0VrwAV%2BKZgSdSpVQcg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>>> >>>> -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/598b7005-9a4b-464c-aad8-ff251959fb7b%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
