Hi, I have complete the work of a PR by other guy done one year ago to fix issue JENKINS-26828.
Since it is my first serius commit as mantainer, could anyone please make a code review on the last commit in the branch https://github.com/jenkinsci/nodejs-plugin/commits/feature/JENKINS-26828 ? I start from the good work of the PR by iaincoulter <https://github.com/iaincoulter> using as much as possible methods and logic in the DownloadFromUrlInstaller super classes, updating some snippets copied in the past from some jenkins core classes. I've test under windows 10. I've also test it with a windows 10 slave node and mac os (sierra) slave node with a windows 10 master node. PS: NodeJS version used in master->slace test enviroment was v4.0.0 (has onyl msi installer for windows) and v7.2.0(a zip installer for windows is available) Thank you -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/4bbc2c36-0050-4235-8832-13f1526d6240%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
