On Thu, Jun 22, 2017 at 8:02 PM, Mark Waite <mark.earl.wa...@gmail.com> wrote: > The git client plugin has tests which assume its branches are full clones. > It uses that assumption to reduce the setup time for submodule tests, tests > of tagging, and more.
Wait, what? It is assuming that the tests are running in a particularly configured checkout of the `git-client-plugin` repository? That is certainly an antipattern. Tests should not even assume that they are running in a Git checkout at all. Could just have been a `cp -ar` from a source tree. Definitely worth cleaning this up if I am understanding correctly what you are saying. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1hQ%2B2po6fcoM-ba72GKat6uCng0xspFDWr3n9f5RK6EQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
