Hi Artem! Thanks for your interest - the docker-workflow plugin definitely could use more attention. That said, it's such a critical plugin that I'd like to see a few more PRs and/or reviews on this plugin from you before giving you full access.
I'll try to look at some of the open PRs over the next week or so and get a release out. In particular I think https://github.com/jenkinsci/docker-workflow-plugin/pull/180 <https://github.com/jenkinsci/docker-workflow-plugin/pull/180> looks like something we definitely want, since it would replace your PR and all other ones trying to fix deficiencies in the Dockerfile parsing (181, 179, 178, 176?, 173, 172, 171, 162, 151, 150, and maybe some others). One of the main reasons this plugin doesn't get updated very often is that behavior changes always seem to cause serious regressions for some subset of users. With that in mind, we are probably not going to be merging any new features unless they include significant testing to make sure they don't cause regressions for existing users, and that they won't regress in the future. If you would like to make fundamental changes to the way the plugin works, it would probably be a better idea to fork and create a new plugin. Feel free to ping myself (dwnusbaum <https://github.com/dwnusbaum>) and Andrew Bayer (abayer <https://github.com/abayer>) on your PRs and we will try to take a look. (Yes I've seen all of the pings on 162, sorry I have not had a chance to look at it yet!) Thanks, Devin > On Jul 22, 2019, at 03:21, Artem Navrotskiy <boz...@gmail.com> wrote: > > Hello, > > I have some comments for docker-workflow-plugin > <https://github.com/jenkinsci/docker-workflow-plugin> that I would like to > fix: > a very naive parsing Dockerfile which not a few works FROM, problem with ARG > (JENKINS-44789 <https://issues.jenkins-ci.org/browse/JENKINS-44789>, > JENKINS-44609 <https://issues.jenkins-ci.org/browse/JENKINS-44609>); > entrypoint/HEALTH CHECK (not working) > https://issues.jenkins-ci.org/browse/JENKINS-54389 > <https://issues.jenkins-ci.org/browse/JENKINS-54389>); > there is no method to remove the container and clean the built containers > after the end of the build; > you cannot create a container without tag; > too many hacks required for use shared cache directories between builds. > The fix part of the problem requires a fairly major bug fixes. > Unfortunately, it seems that the plugin is abandoned: the last commit to the > master was on April 16, and there was no reaction to the trial PR for six > months (https://github.com/jenkinsci/docker-workflow-plugin/pull/162 > <https://github.com/jenkinsci/docker-workflow-plugin/pull/162>). > Basically, I'm ready to maintain this plugin. > > Briefly about me: Artem Navrotskiy, Russia Moscow, 36 years old. > I'm new to the Jenkins community. > My PRs: > https://github.com/jenkinsci/jenkins/pull/4105 > <https://github.com/jenkinsci/jenkins/pull/4105> > https://github.com/jenkinsci/lockable-resources-plugin/pull/138 > <https://github.com/jenkinsci/lockable-resources-plugin/pull/138> > https://github.com/jenkinsci/docker-workflow-plugin/pull/162 > <https://github.com/jenkinsci/docker-workflow-plugin/pull/162> > https://github.com/kohsuke/github-api/pull/530 > <https://github.com/kohsuke/github-api/pull/530> > https://github.com/jenkinsci/github-branch-source-plugin/pull/237 > <https://github.com/jenkinsci/github-branch-source-plugin/pull/237> > https://github.com/jenkinsci/pipeline-gitstatuswrapper-plugin/pull/5 > <https://github.com/jenkinsci/pipeline-gitstatuswrapper-plugin/pull/5>My > open-source projects: > https://github.com/bozaro/git-as-svn <https://github.com/bozaro/git-as-svn> > Jenkins account: Bozaro > GitHub account: bozaro > > -- > Best regards, > Artem Navrotskiy > +7 (925) 095-80-41 > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to jenkinsci-dev+unsubscr...@googlegroups.com > <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAHg4CnH0kfp-UjNds-2VkrNWf4D1xBGRj7916%2BYMVDSzhbg9Ww%40mail.gmail.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/CAHg4CnH0kfp-UjNds-2VkrNWf4D1xBGRj7916%2BYMVDSzhbg9Ww%40mail.gmail.com?utm_medium=email&utm_source=footer>. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/D056192F-4EE0-4893-90B2-F913630F957A%40cloudbees.com.
