+1 from me > On Jan 21, 2020, at 8:40 AM, Arnaud Héritier <aherit...@gmail.com> wrote: > > +1 > it makes sense to me > > On Tue, Jan 21, 2020 at 1:01 PM Oleg Nenashev <o.v.nenas...@gmail.com > <mailto:o.v.nenas...@gmail.com>> wrote: > Dear all, > > TL;DR: I propose to expand the Jenkins Core maintainers team by inviting the > most active code reviewers to the team. > > As you probably know, Jenkins core maintainers capacity has been a > long-standing issue which was impacting the velocity of the Jenkins core and, > in some case, leading to regressions due to missed issues during reviews. In > September 2019 we created a new Core Pull Request Reviewers team > <https://groups.google.com/forum/#!msg/jenkinsci-dev/0sdrcSOQW64/tD-IKDTsBQAJ> > in order to onboard more reviewers and provide a clear path to join the > Jenkins Core team (aka "Jenkins core maintainers"). Currently the reviewers > team <https://github.com/orgs/jenkinsci/teams/core-pr-reviewers/members> > includes 10 members including me and Mark Waite. Mark was added to the > Jenkins Core team in November 2019 as per this discussion > <https://groups.google.com/forum/#!msg/jenkinsci-dev/oDlAVOtHSCo/WCY7s-hHBwAJ>. > > The "onboard more reviewers " part was a huge success IMHO. We largely > increased number of reviews in the Jenkins core. Below you can find some > stats and I extracted from DevStats <https://devstats.cd.foundation/>. Please > take them with a grain of salt, because there are some artifacts I see in > other repositories: > Last quarter we got to almost 700 reviews. Before the change we had 400 > reviews in the previous quarter. (query > <https://jenkins.devstats.cd.foundation/d/46/pr-reviews-by-contributor?orgId=1&from=now-2y&to=now&var-period=q&var-repo_name=jenkinsci%2Fjenkins>). > Quarters are counted till Dec 31, 2019. > During the last quarter the newcomer reviewers team members did more than 150 > reviews (query > <https://jenkins.devstats.cd.foundation/d/46/pr-reviews-by-contributor?orgId=1&from=now-6M&to=now&var-period=q&var-repo_name=jenkinsci%2Fjenkins&var-reviewers=%22timja%22&var-reviewers=%22varyvol%22&var-reviewers=%22halkeye%22&var-reviewers=%22jvz%22&var-reviewers=%22res0nance%22&var-reviewers=%22MRamonLeon%22&var-reviewers=%22alecharp%22&var-reviewers=%22fcojfernandez%22>). > This number is lower than the one above, but apparently it ignores > re-reviews > We went from 2.5 to 4 reviews on average in pull requests. Number of incoming > pull requests was quite stable over past quarters (query > <https://jenkins.devstats.cd.foundation/d/15/new-prs-in-repository-groups?orgId=1&from=now-2y&to=now&var-period=q&var-repogroup_name=jenkinsci%2Fjenkins>). > Note that the review numbers IIUC includes re-reviews. Before introducing > the team we used to merge a lot of PRs with just one review, but it does not > happen anymore > Time to engagement slightly improved, but no drastic improvements there > (query > <https://jenkins.devstats.cd.foundation/d/10/pr-time-to-engagement?orgId=1&from=now-1y&to=now&var-period=q&var-repogroup_name=jenkinsci%2Fjenkins>) > IMHO it is time to proceed with the second part, "provide a clear path to > join the Jenkins Core team". Based on the data, I suggest we expand the core > team by inviting the most active code reviewers to it. Effectively it means > granting merge permissions. I suggest the following: > 5 most active reviewers are invited to join the Jenkins Core maintainers > <https://github.com/orgs/jenkinsci/teams/core> team: Raihaan Shouhell > <https://github.com/res0nance>, Matt Sicker <https://github.com/jvz>, Tim > Jacomb <https://github.com/timja>, Ramon Leon > <https://github.com/MRamonLeon>, Evaristo Gutiérrez > <https://github.com/varyvol> > All maintainers will need to sign individual CLA > <https://github.com/jenkinsci/infra-cla> (and company CLA if needed) before > getting permissions > The team provides access to 32 repositories: Jenkins modules, libraries and > core developer tools like Parent POMs. I will probably clean it up a bit > We ensure that there is a knowledge transfer process established to help new > maintainers > We start doing regular office hours with Q&A and joint PR grooming/review > sessions, e.g. every 2 weeks. I am ready to run such sessions > Maintainer guidelines and best practices are documented in the Jenkins core > repo. We will gradually create this documentation together during KT sessions > > TBD - we create a new public chat for core maintainers so that conversations > can happen outside highly populated #jenkins and jeninsci/jenkins channels in > IRC and Gitter. Maybe YAGNI? > We encourage more contributors to join the reviewers team. Having more > contributors is always great! > What do you think? > > Best regards, > Oleg Nenashev > > Reviews by Core PR reviewers team in this quarter (Oleg and Mark are > excluded): > <image.png> > > Jenkins Core code reviews by quarter: > <image.png> > > Jenkins core pull request by quarter: > <image.png> > > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to jenkinsci-dev+unsubscr...@googlegroups.com > <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCLjPCiveK_PLJ99MG3RuEtrfE4%3DjcxXyfAAtcr5TgdAQ%40mail.gmail.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCLjPCiveK_PLJ99MG3RuEtrfE4%3DjcxXyfAAtcr5TgdAQ%40mail.gmail.com?utm_medium=email&utm_source=footer>. > > > -- > ----- > Arnaud Héritier > http://aheritier.net <http://aheritier.net/> > Mail/GTalk: aheritier AT gmail DOT com > Twitter/Skype : aheritier > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to jenkinsci-dev+unsubscr...@googlegroups.com > <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAFNCU-8E5kx_45mJvZtPzqP0%3D-Ba_P4zzWvzq9KbYDKSzUk8RQ%40mail.gmail.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/CAFNCU-8E5kx_45mJvZtPzqP0%3D-Ba_P4zzWvzq9KbYDKSzUk8RQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.
-- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA0C3FAC-4E2C-40B5-AC04-8CDE315F7324%40gmail.com.
