> Am 30.03.2020 um 13:53 schrieb James Nord <jamestn...@gmail.com>:
> 
> 
> 
> On Thursday, 26 March 2020 21:27:59 UTC, Jesse Glick wrote:
> The main obstacle was that the available annotations in the 
> `edu.umd.cs.findbugs.annotations` package were all `@Deprecated` and 
> told you to use `javax.annotation`, so we would be peppering the 
> source code with deprecation warnings. This seems to have been 
> resolved with 
> 
> https://github.com/jenkinsci/jenkins/pull/4062 
> <https://github.com/jenkinsci/jenkins/pull/4062> 
> 
> Note that JSR 305 is still pulled in as a dep of `spotbugs-annotations`, e.g. 
> 
> @javax.annotation.Nonnull(when = When.MAYBE) 
> 
> but perhaps you can exclude that dep without breaking any tools. 
> 
> https://github.com/jenkinsci/jenkins/pull/4604 
> <https://github.com/jenkinsci/jenkins/pull/4604>
> 
> jsr-305 is excluded from the war but kept in core.  The reason being tooling 
> will pick up if you do something bad with any library that Jenkins pulls in 
> that is using these annotations.

I like the idea! (I also removed the JSR305 dependency from my plugins during 
the warnings-ng rewrite.)

What does that mean for plugins that currently use these JSR 305 annotations 
without an explicit dependency? Will they break if the annotations are not part 
of the war anymore?

> 
> /James
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/e3601d8c-1695-4941-a413-b742f1b21639%40googlegroups.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/e3601d8c-1695-4941-a413-b742f1b21639%40googlegroups.com?utm_medium=email&utm_source=footer>.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/C12A5FD6-2B67-4AD1-8AF4-485225309E3D%40gmail.com.

Reply via email to