Ok, 1. I merged your PR and the reviewed one. Locally it builds for me, but should take a look at where its building in the CI, so I can monitor errors - is there a url? 2. Imported the README in to the git repo, thanks for the link. WIll try clear it up once the code is building and breathing. 3. I guess I am missing still a LICENSE file, there a standard one for Jenkins plugins? Or do I need to go by the original developer?
On Monday, April 6, 2020 at 6:13:55 PM UTC+3, Oleg Nenashev wrote: > > yes, we have a standard Pipeline for Plugin in Jenkins. I have submitted a > pull request for CI here: > https://github.com/jenkinsci/configurationslicing-plugin/pull/26. Plugin > POM is pretty old, and update to recent versions is needed for advanced > checks in our Pipeline > > .Also, I would recommend to migrate documentation to GitHub: > https://jenkins.io/blog/2019/10/21/plugin-docs-on-github/ > <https://www.google.com/url?q=https%3A%2F%2Fjenkins.io%2Fblog%2F2019%2F10%2F21%2Fplugin-docs-on-github%2F&sa=D&sntz=1&usg=AFQjCNHDg8nOF-drSpQgkTUggrAUOndZtw>. > > Wiki is currently read-only, but it is quite trivial to move the docs with > help of tools we provide. > > Hopefully it helps, > > > > On Mon, Apr 6, 2020 at 4:59 PM Guy Sheffer <[email protected] <javascript:>> > wrote: > >> Hey Oleg, thanks for your help! >> Its crazy times for all and perfectly understandable. Glad to do some >> FOSS help meanwhile. >> >> Question - assuming that PR passes review I presume now that I should >> make sure this repo is also built and published - is there some doc on how >> to do that? I built it and tested here locally, but I assume you have some >> kind of CI? >> >> On Sunday, March 15, 2020 at 3:14:58 PM UTC+2, Guy Sheffer wrote: >>> >>> Hey, here is the information as requested in >>> https://wiki.jenkins.io/pages/viewpage.action?pageId=103088172 >>> >>> - >>> >>> Link to a plugin you want to adopt: >>> https://plugins.jenkins.io/configurationslicing/ >>> - >>> >>> Link(s) to pull requests you want to deliver, if applicable: >>> https://github.com/jenkinsci/configurationslicing-plugin/pull/21 >>> Note: this is not my code, however I want to build, fix and manage >>> the plugin >>> - >>> >>> Your GitHub username/id (e.g. oleg-nenashev for >>> https://github.com/oleg-nenashev/) >>> guysoft >>> - >>> >>> Your Jenkins infrastructure account id. Create your account >>> <https://accounts.jenkins.io/> if you don’t have one: guysoft >>> >>> Also, I tried to build the plugin and the build fails (test plugin fro >>> the tutorial works fine). >>> So I want to fix that first. >>> Build output here if anyone can tell me what is going on: >>> https://pastebin.com/reU1DbAt >>> >>> Thanks, >>> >> -- >> You received this message because you are subscribed to a topic in the >> Google Groups "Jenkins Developers" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/jenkinsci-dev/O2cO3zXuDi0/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/7fd5d567-c915-4e22-a1c6-30c2f575279f%40googlegroups.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/7fd5d567-c915-4e22-a1c6-30c2f575279f%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/170c2c4c-8588-4170-b13b-af22d6561b9d%40googlegroups.com.
