On Wed, Mar 30, 2022 at 7:16 AM Basil Crow <m...@basilcrow.com> wrote:
> As part of my work on Java platform support in Jenkins, I have > encountered the subsystem introduced in JENKINS-20679, which allows > plugins to request a newer version of Java than the corresponding > core. Based on a preliminary search of sources across the ecosystem, > this functionality appears to be unused. In my opinion this subsystem > introduces unnecessary complexity, and I would like to remove it to > simplify the implementation of future Java platform changes. In other > words, I am proposing a revert of JENKINS-20679 across all relevant > repositories: core, plugin-pom, maven-hpi-plugin, update-center2, and > any other places where JENKINS-20679 code might have spread. I would > like to thank the original authors of this code for providing a > valuable subsystem that served its purpose faithfully, having now > reached what I consider to be end-of-life. > > Since the amount of work involved in testing these changes (including > searching for usages in binaries, both open-source and proprietary) > and preparing written justifications for the relevant PRs is > non-trivial, I would like to gather at least notional consensus on > this list regarding whether this is a direction we would like to go > in. If the consensus is favorable, I will proceed with testing and > preparing pull requests. However, if there are non-trivial objections > I will focus my time and energy on other areas. > Seems reasonable if really unused. A few considerations: 1. IIRC I've seen plugins requiring Java 11 that just don't declare it. So it's not unused because it isn't needed, but perhaps because plugin authors are unaware of it? 2. Will this be replaced by a different system (assuming this is future proof in principle)? Or will plugins be unable to require higher Java versions than what their core baseline requires to run? Or will there be surprises for admins when attempting to install such plugins? I think the core support for this was essentially a warning in plugin manager. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLGmu72FmZNvUZ3JX4eAX%3D13fK8hM9neOgNdZgZEhMOGg%40mail.gmail.com.
