Please do not troll this out until https://github.com/diffplug/spotless/issues/1559 is fixed - this causes all code to fail for windows users using checkout-as-is and checkin-as-is which is not uncommon for windows users who also share code with the Linux subsytem for windows.
I have battled this for one repository where it was already enabled - and to format the code you need to format everything then apply dos2unix on everything (though should not be windows line ends - and some files may need to be and have appropriate gitattributes). Rather than helping if the first thing a user sees is a lot of wanrings on attempting to build what is just cloned - it will do the opposite. and before anyone suggests users should change their local environment that is a non starter. - the projects should not require anything special except git maven and java (at their supported/required versions) /James On Wednesday, April 12, 2023 at 6:08:15 AM UTC+1 m...@basilcrow.com wrote: > Thanks to everyone who has adopted the new Spotless configuration. I > am trying to get everyone who was already using Spotless migrated over > to the new configuration. Once that happens, I might even be able to > change the opt-in mechanism from the ugly .mvn_exec_spotless file to a > Maven property. > > The next question is: do we want to do the same thing for core and > core components? And if so, do we want it to be opt-in or shall we > apply Spotless unconditionally for core and all core components? I can > do the work, but it would take some time to cover all components. The > question boils down to whether or not the other maintainers are > comfortable with this change. > > The last time we did a large formatting change in core (adding > Prettier) the usual concerns were expressed regarding merge conflicts > in open PRs and difficulty of backports. I think we did a pretty good > job of resolving merge conflicts in open PRs, and we backported the > formatting change in order to address concerns from the security team. > We could adopt that (successful) strategy again in this case, assuming > the same concerns still apply. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/8a2dd389-8287-4d02-8ed8-283590d8c1c6n%40googlegroups.com.
