It was reported here:
https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/272

That the Generic Webhook Trigger Plugin is slow in large installations.

I "solved" that by adding a cache and having it configurable in the global 
config here:
https://github.com/jenkinsci/generic-webhook-trigger-plugin/blob/generic-webhook-trigger-2.1.1/src/main/java/org/jenkinsci/plugins/gwt/global/CacheConfig.java

And implemented cache here:
https://github.com/jenkinsci/generic-webhook-trigger-plugin/blob/generic-webhook-trigger-2.1.1/src/main/java/org/jenkinsci/plugins/gwt/jobfinder/JobFinderImpersonater.java

I'd like to get some feedback on this solution.
- Does this kind of cache really belong in the plugin?
- In order to invalidate the cache, the plugin starts a scheduled task. 
Feels fragile, hard to test and I don't know if it works after a few days 
of uptime.
- Is there a faster way 
to Jenkins.getInstance().getAllItems(ParameterizedJob.class); ?
- Users may not understand the effect of enabling this 
cache 
https://github.com/jenkinsci/generic-webhook-trigger-plugin/issues/302#issuecomment-2051821328

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/cbea2c0c-efa3-4ef2-813b-d8ee3658500an%40googlegroups.com.

Reply via email to