[
https://issues.jenkins-ci.org/browse/JENKINS-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159475#comment-159475
]
Joe Hansche edited comment on JENKINS-12881 at 2/29/12 7:14 AM:
----------------------------------------------------------------
The approach I took on this was to have a configurable error file that can be
specified in the "Gerrit Trigger" section of config, in the Advanced section.
When building the approval message, if the result is not SUCCESS, it attempts
to read from the unsuccessful-message file. If that is configured and the file
is present, its contents will be appended to that build stats section.
-One concern, which my current implementation is susceptible to, is that
currently the file is only read once *all* builds have completed, but that
could result in some data integrity issues. Instead, that file's contents
should be read as soon as the build is completed, and store the contents to the
MemoryImprint instead.- EDIT: this has been fixed in the pull request.
was (Author: jhansche):
The approach I took on this was to have a configurable error file that can
be specified in the "Gerrit Trigger" section of config, in the Advanced
section. When building the approval message, if the result is not SUCCESS, it
attempts to read from the unsuccessful-message file. If that is configured and
the file is present, its contents will be appended to that build stats section.
~One concern, which my current implementation is susceptible to, is that
currently the file is only read once *all* builds have completed, but that
could result in some data integrity issues. Instead, that file's contents
should be read as soon as the build is completed, and store the contents to the
MemoryImprint instead.~ EDIT: this has been fixed in the pull request.
> Allow reading custom build message from a workspace file, in case of
> non-success
> --------------------------------------------------------------------------------
>
> Key: JENKINS-12881
> URL: https://issues.jenkins-ci.org/browse/JENKINS-12881
> Project: Jenkins
> Issue Type: New Feature
> Components: gerrit-trigger
> Affects Versions: current
> Reporter: Joe Hansche
> Assignee: rsandell
> Labels: gerrit
>
> Some background is discussed here:
> https://wiki.jenkins-ci.org/display/JENKINS/Gerrit+Trigger?focusedCommentId=59508437#comment-59508437
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
