[ 
https://issues.jenkins-ci.org/browse/JENKINS-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=161118#comment-161118
 ] 

Lorrin Nelson commented on JENKINS-7830:
----------------------------------------

Hi Ross, thanks again.

Based on GitHub history, looks like the change went into 1.13 so went with that.

In src/main/java/hudson/plugins/sauce_ondemand/SauceOnDemandBuildWrapper.java I 
think the regex is too restrictive: {code}Pattern ENVIRONMENT_VARIABLE_PATTERN 
= Pattern.compile("[$|%]([A-Z]+)");{code}

(I tend to have underscores in my environment variables.) This [StackOverflow 
discussion|http://stackoverflow.com/questions/2821043/allowed-characters-in-linux-environment-variable-names]
 suggests {code}[a-zA-Z_][a-zA-Z0-9_]*{code} might be a good regex.

Also the help text for the port should say port/_PORT instead of host/_HOST in 
this line: "The value of the host will be stored in the SAUCE_ONDEMAND_HOST 
environment variable."

Not working for me yet, but possibly config error on my end to iron out.
                
> using environment variable for local port of ssh tunnel
> -------------------------------------------------------
>
>                 Key: JENKINS-7830
>                 URL: https://issues.jenkins-ci.org/browse/JENKINS-7830
>             Project: Jenkins
>          Issue Type: New Feature
>          Components: sauce-ondemand
>            Reporter: scytacki
>            Assignee: Ross Rowe
>             Fix For: current
>
>
> I use an environment variable to set the port used by the local server that I 
> want to test.  I do this because we want to be able to build/test the hudson 
> job on multiple slave nodes at the same time.  We currently have those slave 
> nodes running on the same machine. If the port is hard coded then I can't 
> startup multiple local servers at the same time because the port will be the 
> same for each and will conflict.
> So it would be helpful if the sauce-ondemand plugin would allow using 
> environment variables for the "Local Port" setting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.jenkins-ci.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to