[JIRA] [git-plugin] (JENKINS-29603) notifyCommit branch parameter can't contain slashes

[martin.danjo...@gmail.com (JIRA)]

Title: Message Title

Martin d'Anjou edited a comment on JENKINS-29603   Re: notifyCommit branch parameter can't contain slashes This code prefixes the repository name to the branch name: https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/GitStatus.java#L266 It makes sense to NOT use the remote repository name when composing the notifyCommit HTTP GET branches parameter. The external world is not supposed to know what names will be used inside the Git Plugin configuration. On the other hand, there are eight documented formats for the branches to build: #  * <branchName> * #  * refs/heads/<branchName> * #  * <remoteRepoName>/<branchName> * #  * remotes/<remoteRepoName>/<branchName> * #  * refs/remotes/<remoteRepoName>/<branchName> * #  * ${ENV_VARIABLE} * #  * <Wildcards> * #  * :<regular _expression_> * According to the code in {{BranchSpec.java}} and {{GitStatus.java}}, I think the first  one  *two*  will never work with {{notifyCommit}}. The last  two  three  may work if constructed properly. So is this issue a bug? I think it can be addressed with proper documentation in the wiki  and perhaps in the help text of the plugin . As for writing tests, I agree that it is necessary. Add Comment   This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.