[JIRA] (JENKINS-14568) Improve commit messages from SCM Sync Configuration

Wed, 25 Jul 2012 08:24:27 -0700

The commit message dialog is only displayed "for the moment" on system configuration page (JENKINS_HOME/configure) and job configuration pages (JENKINS_HOME/jobs/xxx/configure).
If you're on one of these pages and your scm-sync-configuration repo credentials are ok, you should have the dialog prompt (otherwise, it is an issue).

I dislike the instanceof approach because it is opening the door to unwanted cases like this in the code whereas I used a "generic" extension for Saveables in general (which allow, for instance, to specify user-specific sync'ed paths, see JENKINS-8225).
Moreover, I'm pretty sure if I fix current issue, someone else will complain about commit messages which will be too verbose in their particular use of the plugin.

To my POV, there isn't any strong reason why I should go either on the left hand or on the right hand, which would benefits in statu quo.
I can change my mind if you bring some stronger use cases or votes to this issue.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to