[JIRA] [promoted-builds-plugin] (JENKINS-34204) CopyArtifacts build selector broken when using Job DSL + Promoted Builds

[mike.lued...@blackbaud.com (JIRA)]

Title: Message Title

Mike Lueders updated an issue   Jenkins / JENKINS-34204 CopyArtifacts build selector broken when using Job DSL + Promoted Builds Change By: Mike Lueders Description copied from https://github.com/jenkinsci/promoted-builds-plugin/pull/88 The issue is that jenkins ends up interpreting all configuration as 'latest successful build', regardless of how 'buildSelector' is configured. It looks like the resulting config.xml of the copyArtifacts step is incorrect. Specifically, the class of the selector is missing. given the following partial dsl: copyArtifacts('source-job') {     buildSelector {          buildNumber('${PROMOTED_NUMBER}')     } } something like this is generated at the top level: {{ <hudson.plugins.copyartifact.CopyArtifact>     <selector class="hudson.plugins.copyartifact.SpecificBuildSelector">         <buildNumber>${PROMOTED_NUMBER}</buildNumber>     </selector> </hudson.plugins.copyartifact.CopyArtifact> }} but this is what is generated within promotions/actions: {quote}<hudson.plugins.copyartifact.CopyArtifact>     <selector>         <buildNumber>${PROMOTED_NUMBER}</buildNumber>     </selector> </hudson.plugins.copyartifact.CopyArtifact>{quote} The result is Jenkins will mis-interpret the configuration as 'latest' (I'm guessing b/c it's the default class for the selector). I've tracked it down to hudson.plugins.promoted_builds.integrations.jobdsl.PromotionsExtensionPoint#notifyItemCreated(hudson.model.Item, javaposse.jobdsl.plugin.DslEnvironment, boolean), where the conversion to xml is performed - but I don't know enough to venture a guess as to why it works with standard dsl but not when as a promotion step. Add Comment   This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.