Issue Type: Bug Bug
Affects Versions: current
Assignee: Unassigned
Components: cvs
Created: 15/Oct/12 12:51 PM
Description:

ProjectSet files support added in the 2.6 version of the CVS plugin parses incorrectly the psf file. The current regular _expression_ has some shortcomings:

  • If the name of the server contains dots, (cvs.example.org, 192.168.0.24), the parsing fails.
  • If the port is not explicitly set, it also fails, since the colon after the hostname is mandatory, and the _expression_ only acknowledges it before a port (:pserver:host:/cvsroot vs :pserver:host:2401/cvsroot)
  • The module remote name does not support nested folders, since it does not allow slashes (:pserver:host:/cvsroot,CORE/com.example.project,com.example.project)

The following _expression_ solves these problems while keeping the groups, so the rest of the code doesn't need changes:

private static final Pattern PSF_PATTERN = Pattern.compile("<project reference=\"[^,]+,((:[a-z]+:)([a-z|A-Z|0-9|\\.]+)"
			+ "(:([0-9]+)?)([/|a-z|A-Z|_|0-9]+)),(/|[A-Z|a-z|0-9|_|\\.]+),([A-Z|a-z|0-9|_|\\.]+)(,(.*?)){0,1}\"/>");

    
Project: Jenkins
Priority: Major Major
Reporter: Félix velasco
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to