[JIRA] (JENKINS-16314) cvs plugin removes sticky branch tag

Mon, 25 Feb 2013 09:00:59 -0800

Hi Michael, while debugging the code I found the problem is in the cleanout method on the FileCallable inner class on the AbstractCVS.java line 695.
It call entry.setDate(null) that also removes the tag entry as it's stated on its javadoc "Set the sticky date information. Note that setting this will remove any tag information that is currently set."

private void cleanup(File directory, AdminHandler adminHandler) throws IOException {
                            for (File file : adminHandler.getAllFiles(directory)) {
                                Entry entry = adminHandler.getEntry(file);
                                String savedTag = entry.getTag();
                                entry.setDate(null); 
                                
                                adminHandler.setEntry(file, entry);
                            }

I hope that helps your analysis. 
As a quick fix I've changed my AbstractCVS code as below but I'm not fully sure of the consequences.
entry.setDate(null); 
to
String savedTag = entry.getTag();
entry.setDate(null);
if(savedTag != null) { entry.setTag(savedTag); }






Thanks and Regards.

        
                

    		


                    

                		
            

        

    		















            

        		
    

    

        
            This message is automatically generated by JIRA.

            If you think it was sent incorrectly, please contact your JIRA administrators.

            For more information on JIRA, see: http://www.atlassian.com/software/jira
        		
    









-- 

You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

 

 






















					Reply via email to