[JIRA] (JENKINS-16368) Hardcoded protocol in some links

Thu, 28 Feb 2013 11:25:07 -0800

I wrote https://wiki.jenkins-ci.org/display/JENKINS/Hyperlinks+in+HTML that hopefully describes the current design of this in Jenkins.

From that stand point,

  • I disagree with the initial fix (but this was backed out, so I'm good)
  • I also disagree with pull request #682, because it violates Rule #1: no absolute URLs in hyperlinks
  • The proper fix is to update HyperlinkNote so that it does not emit the absolute URL, and rather just use the context path from the current request (it shall fall back to the absolute URL if the code is without the thread-local request, such as when it's used for email-ext plugin)

I'll make the fix accordingly.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply via email to