[JIRA] (JENKINS-13669) NPE in hudson.plugins.mercurial.MercurialSCM.compareRemoteRevisionWith

Thu, 14 Mar 2013 14:17:59 -0700

Jesse Glick commented on Bug JENKINS-13669

Code in question introduced in:

commit bd53013835c998e2b9bc81d8de8bd7581f7d0e8a
Author: Willem Verstraeten <willem.verstrae...@gmail.com>
Date:   Thu Jan 5 18:49:27 2012 +0100

    Implement requiresWorkspaceForPolling
    
    When using caching, all poll operations can be performed on the central cache, so no workspace is necessary

Indeed it is legitimate for possiblyCachedRepo to be null sometimes.

My first inclination would be to then skip the next two lines and continue with workspace-based polling:

if (possiblyCachedRepo != null) {
    FilePath repositoryCache = new FilePath(new File(possiblyCachedRepo.getRepoLocation()));
    return compare(launcher, listener, baseline, output, Hudson.getInstance(), repositoryCache);
}

I am not sure however what Jenkins will do if you first claimed you supported workspaceless polling but then when asked to poll in fact demand a workspace! The Javadoc for SCM is unclear on this point. Worth trying I guess.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply via email to