[JIRA] (JENKINS-17348) Git Plugin: Fast-Remote Polling Does not Filter Branch Name

Mon, 25 Mar 2013 19:00:00 -0700

Debugging has shown the problem in and about in compareRemoteRevisionWithImpl(..) in GitSCM:

final String singleBranch = getSingleBranch(lastBuild);
...
  String gitRepo = getParamExpandedRepos(lastBuild).get(0).getURIs().get(0).toString();
  ObjectId head = git.getHeadRev(gitRepo, getBranches().get(0).getName());

  if (head != null && buildData.lastBuild.getRevision().getSha1().name().equals(head.name())) {

Here singleBranch is able to resolve the branch as a build parameter (in the getSingleBranch(..)), but head always will resolve to null as the branch name is given as a parameter which obviously won't exist in the remote git repo.

It looks like the branch name for head just needs to be filtered in the same ways getSingleBranch(..) does to accept build parameters.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply via email to