Jesse Glick commented on Bug JENKINS-17125

Right, I think the busted serialization format is probably the result of a BuildReference being cleared and a different AbstractBuild being created than the FingerprintAction was originally produced with. So there are two problems:

  1. Making sure that does not happen.
  2. Recovering gracefully from the broken format.

For the second part, your proposed patch is unacceptable (I think) because it breaks the general RunAction contract. I am working on a different patch that acknowledges that the FingerprintAction is incomplete and just limits the damage (no exceptions printed, most things with the fingerprints work).

Not sure what to do about the first part. Seems like a fundamental flaw. (Though I am unable to reproduce it even by making AbstractLazyLoadRunMap.unwrap usually return null.) The best I can think of is to cache all the RunAction instances in a build using strong references so it is guaranteed they will not be collected.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply via email to