Mark Waite commented on Bug JENKINS-16941

Thanks for spending the effort to seek the failing submission. Unfortunately, I think that the actual problem change is hidden in the refactoring which abstracted the Git implementation into an interface, then provided two alternate implementations of that interface, one using the command line Git, the other using JGit. Initially, the default implementation was JGit. With git-client-plugin 1.0.5, the default implementation is now command line Git.

I think the problem was introduced by the refactoring because the problem still exists even after the default implementation was switched from JGit to command line git.

The high level history (as far as I can see), looks something like this:

  • Git plugin 1.1.26 - last version known able to push a merged submission back from a slave agent
  • Git plugin 1.2.0 + Git client plugin 1.0.1 through 1.0.4 - refactored to provide a Git interface, default implementation with JGit
  • Git plugin 1.3.0 + Git client plugin 1.0.5 - bug fixes and switch default implementation to command line Git

Part of me makes the wild guess that this issue would be resolved if we could understand why it cannot serialize. I don't understand the architecture of the slave to master communication, but I thought it was defined by the Java classes and was implemented with Java serialization. My wild guess was that some field or fields were "lost" or "redefined" in the refactoring which break the serialization between the master and slave. However, that is truly just wild guessing on my part.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply via email to