[JIRA] (JENKINS-57694) BuildChooser logs a missing descriptor message

rene.sche...@gmail.com (JIRA) Tue, 10 Sep 2019 14:53:49 -0700

Title: Message Title

Hi Mark Waite I performed an analysis regarding the first message you reported:

 
                                                                java.lang.AssertionError: class jenkins.plugins.git.AbstractGitSCMSource$SpecificRevisionBuildChooser is missing its descriptor 
                                                            

I think it's failing after pull request #709 from Jesse Glick. In there the Descriptor was removed for obvious reasons.

The call chain is as follows:

call 1: https://github.com/jenkinsci/git-plugin/blob/git-4.0.0-beta10/src/main/java/hudson/plugins/git/GitSCM.java#L679

 
                                                                listener.getLogger().println("Using strategy: " + getBuildChooser().getDisplayName());  
                                                            

call 2: https://github.com/jenkinsci/git-plugin/blob/git-4.0.0-beta10/src/main/java/hudson/plugins/git/util/BuildChooser.java#L49

 
                                                                public final String getDescriptorOrDie() {
    return getDescriptor().getDisplayName();
}  
                                                            

call 3: https://github.com/jenkinsci/git-plugin/blob/git-4.0.0-beta10/src/main/java/hudson/plugins/git/util/BuildChooser.java#L229

 
                                                                public BuildChooserDescriptor getDescriptor() {
    return (BuildChooserDescriptor)Jenkins.getInstance().getDescriptorOrDie(getClass()); <--- FAILING HERE: getDescriptorOrDie(...)
}  
                                                            

One quick option to fix this could be to overwrite BuildChooser#getDisplayName (requires to make it non-final) in SpecificRevisionBuildChooser directly. I guess there are better ones but I am not so much into this code.

Mark Waite and Jesse Glick what are you thoughts on this?

Add Comment

This message was sent by Atlassian Jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199629.1558925594000.1028.1568152380144%40Atlassian.JIRA.

[JIRA] (JENKINS-57694) BuildChooser logs a missing descriptor message

Reply via email to