[JIRA] (JENKINS-57205) Null pointer exception in JGit pre-build merge

[be_...@sbcglobal.net (JIRA)]

Title: Message Title

Brian Ray commented on JENKINS-57205   Re: Null pointer exception in JGit pre-build merge Cloning the repo with Git CLI yields different tag types via git show-ref --dereference as above. And the following makes me relatively certain that JGit 4.9.0+ is just now smarter in discerning the two. This is how JGit 4.8.0 sees the tags. ===> [1.6.18.1:[LooseUnpeeled, false, AnyObjectId[c617fb6b71266adb9ca6bff59a89ad7e06638864], null], 3.1.10:[LooseUnpeeled, false , AnyObjectId[94adcf654c5ae0d4d2bb88ec01bdc43ed0bea442], null]] As 4.8.0 treats both tags as LooseUnpeeled, a subtype of Unpeeled, with isPeeled() unconditionally false then JGitAPIImpl.getTags() will return the objectId for both. No nulls. Mark Waite I could attempt a PR to teach JGitAPIImpl.getTags() about the 4.9.0 change in behavior. My initial guess would be something like if (tagRef.isPeeled() && tagRef.getPeeledObjectId() != null ) { peeledTags.add(new GitObject(tagName, tagRef.getPeeledObjectId())); } else if (!tagNames.contains(tagName)) { peeledTags.add(new GitObject(tagName, tagRef.getObjectId())); } It's also possible that JGit is not just behaving differently but behaving incorrectly now, though I'm much less confident in trying to troubleshoot that. What do you think? Add Comment   This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198962.1556378819000.7639.1581456300253%40Atlassian.JIRA.