![]() |
|
|
|
|
Issue Type:
|
![Improvement]() Improvement
|
|
Affects Versions:
|
current |
|
Assignee:
|
Jacob Robertson
|
|
Components:
|
view-job-filters |
|
Created:
|
18/Jun/13 1:32 PM
|
|
Description:
|
parameter filter can only filter by StringParameterValue, BooleanParameterValue and FileParameterValue. So we can't filter by custom parameters.
I can't understand why can't we change ParameterFilter class getStringValue function to something like this:
protected String getStringValue(ParameterValue value) {
if (value instanceof StringParameterValue) {
return ((StringParameterValue) value).value;
} else if (value instanceof BooleanParameterValue) {
boolean bval = ((BooleanParameterValue) value).value;
return String.valueOf(bval);
} else if (value instanceof FileParameterValue) {
// not the full path - just the name
// this is the only public value available to us
String file = ((FileParameterValue) value).getOriginalFileName();
return file;
} else {
return value.toString();
}
}
mine difference is return value.toString(); not return null;
|
|
Project:
|
Jenkins
|
|
Priority:
|
![Critical]() Critical
|
|
Reporter:
|
Maris Zulis
|
|
|
|
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit
https://groups.google.com/groups/opt_out.
