teilo commented on Bug JENKINS-18391

Server is the original 2.5 release.

I see the same entry if I also restart the communication channel
(http://jenkinsurl/gerrit-trigger/ control->restart)

The output of the command 'ssh -p 29418 myuser@gerritServer gerrit version'
is "gerrit version 2.5"

Looking at the code - isn't there a race condition after creating the manager and then fetching the version in the same thread - yet the version is fetched from gerrit in another thread (on the connect method in?

Jun 20, 2013 10:52:47 AM com.sonyericsson.hudson.plugins.gerrit.gerritevents.GerritHandler shutdown
INFO: Shutting down the ssh connection.
Jun 20, 2013 10:52:47 AM com.sonyericsson.hudson.plugins.gerrit.trigger.PluginImpl startConnection
INFO: Started
Jun 20, 2013 10:52:47 AM com.sonyericsson.hudson.plugins.gerrit.gerritevents.GerritHandler run
INFO: Starting Up...
Jun 20, 2013 10:52:47 AM com.sonyericsson.hudson.plugins.gerrit.trigger.version.GerritVersionChecker createVersionNumber
SEVERE: Gerrit version number is null or the empty string.
Jun 20, 2013 10:52:47 AM com.sonyericsson.hudson.plugins.gerrit.gerritevents.GerritHandler run
INFO: Ready to receive data from Gerrit

Note that the version checked is called before gerrit is ready to receive data - which is the log line directly after the call that gets the version from the server?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

Reply via email to