![]() |
|
|
|
|
Issue Type:
|
![New Feature]() New Feature
|
|
Affects Versions:
|
current |
|
Assignee:
|
Unassigned |
|
Components:
|
github, github-api |
|
Created:
|
11/Nov/13 3:01 PM
|
|
Description:
|
When two or more pushes happen in a small time frame, the github webhook in jenkins triggers multiple builds just fine. However, each of these builds is for the latest SHA in that git repository. Example:
01:01:01 - User 1 pushes sha #1 to master branch
01:01:02 - User 2 pushes sha #2 to master branch
Jenkins receives the two POSTs and triggers two builds. Each of these builds simply does a git pull and starts the build script at sha #2. This has the side effect of never building sha #1 by itself.
I'm not so great at Java, but looking at the GitHubPushTrigger.java file here:
https://github.com/jenkinsci/github-plugin/blob/master/src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java
It appears to never inspect the payload from the github call. Is it possible to have this code inspect the payload and build based off of the 'after' key? There is an example of the payload here:
https://help.github.com/articles/post-receive-hooks
I don't know how possible this is, but it would seem to be a great addition to the github plugin.
|
|
Project:
|
Jenkins
|
|
Labels:
|
plugin
github
|
|
Priority:
|
![Major]() Major
|
|
Reporter:
|
Allan Feid
|
|
|
|
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit
https://groups.google.com/groups/opt_out.
