![]() |
|
|
|
|
Issue Type:
|
![Bug]() Bug
|
|
Affects Versions:
|
current |
|
Assignee:
|
Honza Brázdil
|
|
Components:
|
ghprb |
|
Created:
|
31/Mar/14 9:11 PM
|
|
Description:
|
Github enterprise returns 404 http://mygithubserver.com/api/v3/rate_limit and the body of this request is {"message": "No rate limit for white listed users"}. This is the expected behavior of github since there is no limit for white listed users, so it returns 404 and a friendly message.
This link has an exemple of this problem affecting other application:
https://github.com/joomla/joomla-framework/issues/280
ghprb doesn't see that way, It raises an exception as follows:
Mar 31, 2014 3:39:15 PM SEVERE org.jenkinsci.plugins.ghprb.GhprbRepository checkState
Error while accessing rate limit API
java.io.FileNotFoundException: http://mygithubserver.com/api/v3/rate_limit
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1610)
at org.kohsuke.github.Requester.parse(Requester.java:298)
at org.kohsuke.github.Requester._to(Requester.java:175)
at org.kohsuke.github.Requester.to(Requester.java:141)
at org.kohsuke.github.GitHub.getRateLimit(GitHub.java:220)
at org.jenkinsci.plugins.ghprb.GhprbRepository.checkState(GhprbRepository.java:57)
at org.jenkinsci.plugins.ghprb.GhprbRepository.check(GhprbRepository.java:77)
at org.jenkinsci.plugins.ghprb.Ghprb.run(Ghprb.java:72)
at org.jenkinsci.plugins.ghprb.GhprbTrigger.run(GhprbTrigger.java:181)
at hudson.triggers.Trigger.checkTriggers(Trigger.java:261)
at hudson.triggers.Trigger$Cron.doRun(Trigger.java:209)
at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:54)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)
ghprb should handle 404 as unlimit in this request, since an user in white list, doesn't have a limit.
|
|
Environment:
|
Acessing github enterprise
|
|
Project:
|
Jenkins
|
|
Priority:
|
![Major]() Major
|
|
Reporter:
|
Thiago Papageorgiou
|
|
|
|
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit
https://groups.google.com/d/optout.
