|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Code changed in jenkins
User: Oliver Gondža
Path:
src/main/java/org/jenkinsci/test/acceptance/selenium/SanityChecker.java
http://jenkins-ci.org/commit/acceptance-test-harness/fcb045f263ca7722d182a858684f0e7ac9b7a6cd
Log:
JENKINS-23069 A bit nicer way of sanity checking
There are several problems:
1) Checking after navigation is not enough as it is triggered only if navigating explicitly via WebDriver. Clicking links/buttons is not covered.
2) Sanity checking need to access page source witch triggers UnhandledAlertException in case alert is present, in firefox alert is dismissed at this point.
3) Checking if alert is present upfront (`driver.switchTo().alert()`) is hideously slow (1-2 seconds).
Moving the check to #beforeClickOn and #beforeNavigateTo so it is no longer necessary to handle alerts (any alert present at this point is clearly unhandled). We can add checking to #onException at any time.
This fixes DiskUsagePluginTest#reflect_disk_changes_in_disk_usage_report (problem #2).
Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/bd29f60f8795...fcb045f263ca