|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Hi Rin.
I would consider it a critical issue, if
I am also not sure, if your assumptions about how many builds should be scheduled for events are entirely valid.
After all, the Gerrit Trigger plugin has another way of retriggering all builds belonging to a given patch-set:
This button does – from the user perspective – the same thing as the "manual trigger" and it works absolutely correctly – because it can only be run, if all builds on that patch-set have finished.
That's the only reason it works. The manual trigger works, too, if you also wait until all builds for patch-set have finished.
Both features only break if you let them start concurrently with running tests.
But the problem is, that the manual trigger allows you to do that while other builds for the same patch-set are running. Since it does not check for this, it must work correctly even when builds are still running.
Otherwise, this feature is a direct way to break the entire purpose of the plugin.
And the nastiest thing: It breaks it without feedback. Nothing indicates that this behaviour breaks stuff. There isn't even an easy way to ensure that you can use that feature safely, as it not easy to find out which patch-sets are currently under test.