|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Ali Raza:
>From a technical POV, yes. The package names for logging and the option name would change, that's it. Note that there is no functional or other advantage for you other than this feature being included without installing another plugin; for example the addition to the folder config form uses the same API as e.g. the similar Credentials-related options. In fact, functionally it'd be better left separate, as it'd allow users on older Jenkins + Folders versions to use it as well once I reduce the version requirements.
Whether the addition would be accepted by the Folders maintainers is another question. Since this proposal was filed by CloudBees employees I'm hopeful, but whether the specific implementation is acceptable, I don't know. If changes are requested by them, you'd have to evaluate which you prefer.
Do you have any other comments/requests regarding this plugin? Is the functionality as expected? Are the parts in which I differed from the acceptance criteria acceptable? (What's still missing is the inline help for the two options, that's still on the todo list.)