Tom Jones commented on Improvement JENKINS-24980

Currently plugin does this:

launcher.launch().envs(envs).cmds("/usr/bin/security", "list-keychains", "-s", keychainPath).stdout(listener).pwd(projectRoot).join();

which is the equivalent of this:

security list-keychains -s ${KEYCHAIN_PATH}

Needs to do this:
security list-keychains | xargs security list-keychains -s "${KEYCHAIN_PATH}"

And then when finished building, the plugin should do the equivalent of this:
security delete-keychain "${KEYCHAIN_PATH}"

Not entirely sure how the first part would be done in java.

Unrelated matter that this also fixes, the Keychain is left in the workspace, and its password is shown in plain text in the environment variables, which allows a developer on your team to download the keychain, unlock and extract the private keys (which raises the question, why have a password?)

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to