Issue Type: Bug Bug
Assignee: Sam Kottler
Components: github-oauth-plugin
Created: 04/Feb/15 3:17 PM
Description:

Overview
---------
The Github repository permissions feature of the Github Commiter Authorization Strategy in the github-oauth-plugin throws a fatal error when the Github URL for the Job is an invalid URL (e.g., 404). The authorization strategy should fail gracefully when the repo URL is invalid.

Steps To Reproduce
------------------
1) Configure Jenkins Global security (http://jenkins/configureSecurity) to use the Github Authentication Plugin and use the "Github Commiter Authorization Strategy" with the option enabled for "Use Github repository permissions"
2) Create a new Job with a Git SCM provider (e.g., "MyJob")
3) Enter an invalid Git Repository URL that does not exist (e.g., g...@github.com:MyOrg/wrong-repo-name.git instead of g...@github.com:MyOrg/correct-repo-name.git)
4) Save the Job config (note: ignore the warnings about an invalid Git URL; we've seen valid URLs renamed, moved to new orgs, etc)

Actual Result
-------------
The Jenkins web UI URL for the Job (e.g., http://jenkins/job/MyJob) responds with a 500 error caused by a NullReferenceException in the Github authorization strategy

Expected Result
---------------
The Jenkins web UI URL for the job should respond with a 200 and render the normal view for the job. Attempts to build the job should fail due to the invalid Git URL.

Environment: Jenkins ver. 1.532.1 (LTS)
GitHub OAuth Plugin 0.20 (latest)
Project: Jenkins
Priority: Minor Minor
Reporter: Steve Jansen
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira

--
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to