[ http://issues.apache.org/jira/browse/JS2-222?page=comments#action_63375 ]
     
Ate Douma commented on JS2-222:
-------------------------------

I'm going to commit a rewrite of the DecoratorAction creation and evaluation, 
together with a lighter implementation of the cached page and fragment action 
access security in the session.

All fragment action access security will be stored as bit flags in a HashMap 
contained in a new page based PageActionAccess component, replacing the current 
PortletWindowActionState component.
This new component handles all access evaluation itself and is stored in the 
session for each page.
It state also will be reset after a user logged on, effectively resolving this 
issues problem.

Note: 
I will comment out using AccessController.checkPermission for fragment action 
access evaluation!
In the current implementation it is used but its result is inversed because 
right now it always returns false!
Once we have PorletPermission evaluation (for DecoratorActions at least) truly 
implemented/supported this can be enabled again easily, but right now its just 
a performance drain without any reason.

Furthermore, DecoratorActions (which contains a PortletURL for changing the 
current PortletMode or WindowState) now will no longer be cached as that could 
break the Portlet API requirement for maintaining current Render parameters 
(which occurs if not the SessionFullNavigationalState is used).

Finally, to support true browser caching of DecoratorAction image links, these 
now will be created off the PortalURL.getPageBasePath(): possible encoded 
NavigationalState within the current request url won't be part of the image url 
anymore.


> Problems getting into edit mode
> -------------------------------
>
>          Key: JS2-222
>          URL: http://issues.apache.org/jira/browse/JS2-222
>      Project: Jetspeed 2
>         Type: Bug
>     Versions: 2.0-dev/cvs
>     Reporter: Jouni Rajala
>     Assignee: Ate Douma

>
> I am using JS2 from CVS/HEAD and checked it out couple of days ago.
> Problem is that after logging in as administrator I can't get into edit mode 
> of
> portlets. Edit mode icon is missing from portlet entirely. After I once 
> minimize
> or maximize the portlet, edit mode icon appears and works normally.
> On some pages it seems to work ok. Can't find any logic why it works
> on some pages and why not on some others. I am using stock pages from
> CVS and I haven't modified them in any way.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to