James Liao wrote:
Hi all,
I think the optimize for DynamicTitleServiceImpl have a problem.
If a portlet's Resources doesn't contain javax.portlet.title property,
the portlet will lost its title. For example, almost all the
Administrative portlet have this problem.
I have do a little bit investigated on it. I found the cause of this
is in LanguageImpl and LanguageSetImpl. The LanguageImpl's method:
setTitle(), setShortTitle() and setKeywords() will not set the value
into DefaultsResourceBundle object's defaultValues Map.
So can not use the LanguageSetImpl's createLanguage method like this:
createLanguage(lang.getLocale(), loadResourceBundle(lang.getLocale()),"","","");
language.setTitle(lang.getTitle());
language.setShortTitle(lang.getShortTitle());
language.setKeywords(StringUtils.join(lang.getKeywords(), ","));
Should be used like this:
createLanguage(lang.getLocale(), loadResourceBundle(lang.getLocale()),
lang.getTitle(), lang.getShortTitle(),
StringUtils.join(lang.getKeywords(), ","));
If it is necessary, I could raise a bug for this and provide a patch.
Thanks (again) James
I'll apply this patch and see how it works here today
Regards,
--
David Sean Taylor
Bluesunrise Software
[EMAIL PROTECTED]
[office] +01 707 773-4646
[mobile] +01 707 529 9194
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
