[ 
https://issues.apache.org/jira/browse/JS2-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545093
 ] 

Dennis Dam commented on JS2-809:
--------------------------------

the patch looks ok (especially since all the spring config is commented :), 
although a couple of questions:

- what are the differences between 
org.springframework.jdbc.datasource.TransactionAwareDataSourceProxy (which you 
extend) and org.apache.commons.dbcp.BasicDataSource (the default datasource) . 
Why did you choose for the one from Spring ?

- The property maxRetriedStarts in /src/webapp/WEB-INF/assembly requires the 
patch described in https://issues.apache.org/jira/browse/JS2-666 right ? In 
that case it might be an idea to either relate this issue to JS2-666, or remove 
the property.



> Add table schema aware datasource proxy
> ---------------------------------------
>
>                 Key: JS2-809
>                 URL: https://issues.apache.org/jira/browse/JS2-809
>             Project: Jetspeed 2
>          Issue Type: New Feature
>          Components: Persistence and DAO
>    Affects Versions: 2.1, 2.1.2, 2.1.3, 2.2
>            Reporter: Joachim Müller
>             Fix For: 2.1.3, 2.2
>
>         Attachments: patch.diff
>
>
> In some environments (DB2, Oracle, PostGres) the table schema may be not 
> equally associated with the user name, provided in the jdbc connection 
> parameters. At the moment it is not possible to set the table schema used for 
> the db connections.
> This table schema aware datasource proxy optionally injects a schema 
> selection sql statement into an existing database connection. It proxies a 
> DataSource and executes an injected sql statement on every getConnection() 
> call.
> The proxy can be configured via the spring configurations files and therefore 
> allows to add table schema support to the import functionality only. This 
> might come in handy if you have to import into a certain table schema and 
> cannot rely on the web application container datasource configuration that 
> might already support table schemas (like websphere does).
> The solution was inspired from 
> http://forum.springframework.org/showthread.php?t=10728, although the runtime 
> schema switching functionality was stripped.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to