Dennis,
Thanks again for your patch.
I've refactored it a little (moving it to a separate
MockPortletRegistryFactory) but it definitely helped me out a lot fixing this
and the TestLayout testcase.
These two testcases indeed also needed column positioning adjustments and a few
other changes to get them working again.
But, as of now, and for now, all tests are passing again :)
Regards,
Ate
Dennis Dam wrote:
Hi,
I was looking at the broken testcase TestPortletPlacement, which tests
the recently (heavily) refactored PortletPlacementContextImpl. The
constructor of PortletPlacementContextImpl was changed, so I added some
JMock objects to account for this, see the attached patch.
*however*, the tests are still broken, and this is something I don't
know how to fix, because I don't know the specs are. The problem: the
mock test data has 1-based column numbering, but the
PortletPlacementContextImpl seems to need a 0-based column count ( see
the method getColumnFromFragment() ). The result is that the column with
column nr. = column-count is reset to column-count - 1, which results in
all fragments from both column 1 and 2 ending up in the same column.
What should the behaviour be, columns must be 0-based ? In that case all
the column nrs in FragmentUtil and TestPortletPlacemen must decreased by 1.
regards,
Dennis
------------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
