Author: woonsan
Date: Tue Nov 27 01:55:10 2007
New Revision: 598577

URL: http://svn.apache.org/viewvc?rev=598577&view=rev
Log:
Fixing a testcase: TestPortalSite always fails on a non-English system because 
it assumes that the default locale is English on the test machine. For example, 
`assertEquals("Back to", backMenu.getTitle());' always fails because 
backMenu.getTitle() is equivalent to backMenu.getTitle(Locale.getDefault()). 
(The default locale is ko_KR in my case.)
There are too many codes assuming English locale, but keeping these as before 
seems better to read.
Therefore, I added default locale setting code before testing for non-English 
testing environments.

Modified:
    
portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal-site/src/test/org/apache/jetspeed/portalsite/TestPortalSite.java

Modified: 
portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal-site/src/test/org/apache/jetspeed/portalsite/TestPortalSite.java
URL: 
http://svn.apache.org/viewvc/portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal-site/src/test/org/apache/jetspeed/portalsite/TestPortalSite.java?rev=598577&r1=598576&r2=598577&view=diff
==============================================================================
--- 
portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal-site/src/test/org/apache/jetspeed/portalsite/TestPortalSite.java
 (original)
+++ 
portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal-site/src/test/org/apache/jetspeed/portalsite/TestPortalSite.java
 Tue Nov 27 01:55:10 2007
@@ -57,6 +57,11 @@
      * portalSite - PortalSite component
      */
     private PortalSite portalSite;
+    
+    /**
+     * default locale
+     */
+    private Locale defaultLocale;
 
     /* (non-Javadoc)
      * @see junit.framework.TestCase#setUp()
@@ -66,6 +71,8 @@
         super.setUp();
         this.pageManager = (PageManager) ctx.getBean("pageManager");
         this.portalSite = (PortalSite) ctx.getBean("portalSite");
+        this.defaultLocale = Locale.getDefault();
+        Locale.setDefault(Locale.ENGLISH);
     }
 
     /* (non-Javadoc)
@@ -74,6 +81,7 @@
     protected void tearDown() throws Exception
     {
         super.tearDown();
+        Locale.setDefault(this.defaultLocale);
     }
 
     /**



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to