Author: woonsan
Date: Mon Dec 14 17:59:08 2009
New Revision: 890416

URL: http://svn.apache.org/viewvc?rev=890416&view=rev
Log:
JS2-1084: fixing the problem that portlet is not removed in FF.
In FF 3.0.xx, the css ID selector does not work properly with ID containing 
'.'. 
A workaround is to use css attribute selector.
For example, Y.Node.one("#my.id") can be replaced by Y.Node.one("[id='my.id']").

Modified:
    
portals/jetspeed-2/portal/trunk/applications/jetspeed/src/main/webapp/jetui/engine/portal.js

Modified: 
portals/jetspeed-2/portal/trunk/applications/jetspeed/src/main/webapp/jetui/engine/portal.js
URL: 
http://svn.apache.org/viewvc/portals/jetspeed-2/portal/trunk/applications/jetspeed/src/main/webapp/jetui/engine/portal.js?rev=890416&r1=890415&r2=890416&view=diff
==============================================================================
--- 
portals/jetspeed-2/portal/trunk/applications/jetspeed/src/main/webapp/jetui/engine/portal.js
 (original)
+++ 
portals/jetspeed-2/portal/trunk/applications/jetspeed/src/main/webapp/jetui/engine/portal.js
 Mon Dec 14 17:59:08 2009
@@ -176,16 +176,11 @@
         }
     });
 
-    var cleanseForSelector = function(s) {
-       return s.replace(/(\.|\#)/g, "\\$1");
-    }
-    
     var onRemoveComplete = function(id, o, args) { 
        var id = id; // Transaction ID. 
        var data = o.responseText; // Response data. 
        var widgetId = args[0];
-       widgetId = cleanseForSelector(widgetId);
-       var widget = Y.one("#" + widgetId);
+       var widget = Y.one("[id='" + widgetId + "']");
        if (widget)
        {
                var parent = widget.get('parentNode');
@@ -198,7 +193,7 @@
                        });
                }
        }
-    };     
+    };
     
     var onClickRemove = function(e) {
        var uri = document.location.href;
@@ -210,10 +205,10 @@
        windowId = windowId.replace("jetspeed-close-", "");
        var uri = uri + "?action=remove&id=" + windowId;        
         Y.on('io:complete', onRemoveComplete, this, [windowId]); 
-        var request = Y.io(uri); 
+        var request = Y.io(uri);
     };
 
-    var closeWindows = Y.Node.all('.portlet-action-close');    
+    var closeWindows = Y.Node.all('.portlet-action-close');
     closeWindows.each(function(v, k) {
         v.on('click', onClickRemove);
     });



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to