Open a bug in Bugzilla (http://nagoya.apache.org/bugzilla/) and attach your patch to this bug in a "diff -u" format.
-- Rapha�l Luta - [EMAIL PROTECTED] Jakarta Jetspeed - Enterprise Portal in Java http://jakarta.apache.org/jetspeed/ > -----Message d'origine----- > De : Ryan Christianson [mailto:[EMAIL PROTECTED] > Envoy� : lundi 3 mars 2003 20:14 > � : Jetspeed Users List > Objet : small JetspeedIdGeneratorService fix > > > The class JetspeedIdGeneratorService has the method in cvs: > > public String getNextPeid() > { > synchronized(JetspeedIdGeneratorService.class) > { > idCounter++; > } > > return peidPrefix + > Long.toHexString(System.currentTimeMillis()) + "-" > + Long.toHexString(idCounter) + peidSuffix; > } > > It seems to me that this would be more thread save: > > public String getNextPeid() > { > long newId; > synchronized(JetspeedIdGeneratorService.class) > { > newId = idCounter++; > } > > return peidPrefix + > Long.toHexString(System.currentTimeMillis()) + "-" > + Long.toHexString(newId) + peidSuffix; > } > > Otherwise the idCounter could be updated before the string is built. > > Is the correct place to submit cvs changes like this? > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > ********************************************** Vivendi Universal - HTTP://www.vivendiUniversal.com: The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material of Vivendi Universal which is for the exclusive use of the individual designated above as the recipient. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact immediately the sender by returning e-mail and delete the material from any computer. If you are not the specified recipient, you are hereby notified that all disclosure, reproduction, distribution or action taken on the basis of this message is prohibited. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
