Hi Eugene,
You were right.
I fixed that now too. Please restore the old patch and try with this one.
Thanks, Javier
Eugene Turovsky wrote:
Hi Javier,
Patch works, but not entirely. In case when I have 2-workplace view (like maps&events and so on) it works. If I have only 1 workplace (like hosts or performance view), it doesn't work with error:"Error: frame.show is not a function".
Kind regards, Eugene Turovsky
Hi Eugene
Please try this patch and let me know if it works under a frame now.
I tested it here under Firefox and IE with a frame and a popup and it worked.
Javier
Eugene Turovsky wrote:
Hi,
JFFNMS ver. 0.8.0-rc1. Tools don't work properly.
When Tools was launched from interface pop-up menu it work (but current
values shown only after refreshing, may be better load values right away?)
It's loaded in new window.
When Tools was launched from performance window (t.e. inside frame with
top menu), it not work. I select some checkboxes and click refresh,
window show "Fetching" and that's all. In JavaScript Console I see
error: "Error: parent.show is not a function".
-- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Javier Szyszlican, Project Leader, JFFNMS [EMAIL PROTECTED]
I hope JFFNMS or I were helpful to you, if you can, please donate at http://jffnms.org/donate
diff -x'*map' -x'*dot' -x'*ini' -x'*png' -x'*log' -x'*patch' -x'*diff'
-x'*.mysql' -x'*.pgsql' -x'*rrd' -x'*ini-200*' -x'*.dat' -x'*.ini.old' -Nru
jffnms-0.8.0-rc2/htdocs/admin/tools.php jffnms-0.8.0/htdocs/admin/tools.php
--- jffnms-0.8.0-rc2/htdocs/admin/tools.php 2005-02-09 18:01:31.000000000
-0300
+++ jffnms-0.8.0/htdocs/admin/tools.php 2005-02-14 13:50:22.350551336 -0300
@@ -99,7 +99,8 @@
die();
}
- $iframe = html("iframe","","NAME","", "name='NAME' OnLoad=\" if (src!='')
parent.show(this);\"");
+ $iframe = html("iframe","","NAME","", "name='NAME' ".
+ "OnLoad=\" if (src!='') { frame =
(parent.map)?parent.map:((parent.work)?parent.work:parent); frame.show(this);
}\"");
$refresh=0;
adm_header("Tools");
@@ -129,10 +130,10 @@
" name = iframe.name;\n".
" if (iframe.set == true) { \n".
" result = 'result'+name.substr(6,name.length);\n".
- " document.getElementById(result).innerHTML =
parent.frames[name].document.body.innerHTML;\n".
+ " document.getElementById(result).innerHTML =
this.frames[name].document.body.innerHTML;\n".
" } else {\n".
" div = 'tool'+name.substr(6,name.length);\n".
- " document.getElementById(div).innerHTML =
parent.frames[name].document.body.innerHTML;\n".
+ " document.getElementById(div).innerHTML =
this.frames[name].document.body.innerHTML;\n".
" result = 'result'+name.substr(6,name.length);\n".
" document.getElementById(result).innerHTML = '<font
color=green>DONE</font>'\n".
" }\n".
