On Wed, 2006-12-06 at 23:27 +0100, Miha Verlic wrote:
> >> Are there any special conditions where jfs would set nointegrity flag on
> >> partition whitout defining it at mount/remount?
> >
> > Not that I know of.  Playing around with mount -o remount, it looks like
> > remounts unexpectedly grab mount options out of /etc/fstab, but I'm
> > assuming you don't have it specified there.  (Or do you?)
> 
> nope, only noatime,nodiratime,usrquota

Doh!  I just found the problem:

#define JFS_NOINTEGRITY 0x00000010

#define JFS_USRQUOTA    0x00000010

This has been broken since 2.6.14.  How embarrassing.  I'm not sure why
I wasn't able to recreate it.  I probably did something stupid.

Here's a patch that should fix the problem.  I am going to push a patch
to mainline that does this and also reorders the definitions in the
header file to avoid making the same mistake again.

diff -Nurp linux-2.6.18/fs/jfs/jfs_filsys.h linux/fs/jfs/jfs_filsys.h
--- linux-2.6.18/fs/jfs/jfs_filsys.h    2006-09-19 22:42:06.000000000 -0500
+++ linux/fs/jfs/jfs_filsys.h   2006-12-06 17:52:24.000000000 -0600
@@ -30,7 +30,7 @@
  *      file system option (superblock flag)
  */
 /* mount time flag to disable journaling to disk */
-#define JFS_NOINTEGRITY 0x00000010
+#define JFS_NOINTEGRITY 0x00000040
 
 /* mount time flags for error handling */
 #define JFS_ERR_REMOUNT_RO 0x00000002   /* remount read-only */

> 
> --
> Miha
-- 
David Kleikamp
IBM Linux Technology Center


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Jfs-discussion mailing list
Jfs-discussion@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jfs-discussion

Reply via email to