On Tue, 2007-10-16 at 20:08 +0200, Christian Kujau wrote:
> Dave,
>
> On Mon, 15 Oct 2007, Charles Perreault wrote:
> > [189028.668269] ERROR: (device md0): diUpdatePMap: inode 4122 not marked
> > as allocated in wmap!
>
> Why is it that the errormessage does not mention "jfs" at all?
> At first I thought
> "Hm, it says 'device', must be a device issue, not filesystem related".
> Sure, after grepping for this printk, jfs/super.c showed up...but how
> about:
>
> --- linux/fs/jfs/super.c.orig 2007-10-16 19:51:22.000000000 +0200
> +++ linux/fs/jfs/super.c 2007-10-16 19:52:04.000000000 +0200
> @@ -79,7 +79,7 @@
> panic("JFS (device %s): panic forced after error\n",
> sb->s_id);
> else if (sbi->flag & JFS_ERR_REMOUNT_RO) {
> - jfs_err("ERROR: (device %s): remounting filesystem "
> + jfs_err("JFS (device %s): remounting filesystem "
> "as read-only\n",
> sb->s_id);
> sb->s_flags |= MS_RDONLY;
> @@ -97,7 +97,7 @@
> vsnprintf(error_buf, sizeof(error_buf), function, args);
> va_end(args);
>
> - printk(KERN_ERR "ERROR: (device %s): %s\n", sb->s_id, error_buf);
> + printk(KERN_ERR "JFS (device %s): %s\n", sb->s_id, error_buf);
>
> jfs_handle_error(sb);
> }
>
>
> And there are plenty of other places where there's no label "jfs:" (but
> this is true for other subsystems too). I'm not sure if JFS needs error
> messages like the Reiser folks ("zam-7001: io error in %s") have, but a
> slightly bigger hint who's to blame could be nice, IMHO.
You make a very good point. I'll make a note to clean up all of jfs's
error messages to be more clear (or at least the one's that need it).
Thanks,
Shaggy
>
> Christian.
--
David Kleikamp
IBM Linux Technology Center
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Jfs-discussion mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jfs-discussion
