> On 23 January 2017 at 19:43 Dave Kleikamp <dave.kleik...@oracle.com> wrote: > > > On 01/23/2017 11:50 AM, Fabian Frederick wrote: > > See i_size_read() comments in include/linux/fs.h > > Is this fixing a real problem? Can the bd_inode size change while we're > mounting or resizing the filesystem? >
Behind good locking, there should be no problem. I made some patches like this to use read operation to remove any ambiguity. Regards, Fabian > > > > Signed-off-by: Fabian Frederick <f...@skynet.be> > > --- > > fs/jfs/resize.c | 4 ++-- > > fs/jfs/super.c | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c > > index bd9b641..7ddcb44 100644 > > --- a/fs/jfs/resize.c > > +++ b/fs/jfs/resize.c > > @@ -98,7 +98,7 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, > > int newLogSize) > > goto out; > > } > > > > - VolumeSize = sb->s_bdev->bd_inode->i_size >> sb->s_blocksize_bits; > > + VolumeSize = i_size_read(sb->s_bdev->bd_inode) >> sb->s_blocksize_bits; > > > > if (VolumeSize) { > > if (newLVSize > VolumeSize) { > > @@ -211,7 +211,7 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, > > int newLogSize) > > txQuiesce(sb); > > > > /* Reset size of direct inode */ > > - sbi->direct_inode->i_size = sb->s_bdev->bd_inode->i_size; > > + sbi->direct_inode->i_size = i_size_read(sb->s_bdev->bd_inode); > > > > if (sbi->mntflag & JFS_INLINELOG) { > > /* > > diff --git a/fs/jfs/super.c b/fs/jfs/super.c > > index c64c257..ad02f00 100644 > > --- a/fs/jfs/super.c > > +++ b/fs/jfs/super.c > > @@ -283,7 +283,7 @@ static int parse_options(char *options, struct > > super_block *sb, s64 *newLVSize, > > } > > case Opt_resize_nosize: > > { > > - *newLVSize = sb->s_bdev->bd_inode->i_size >> > > + *newLVSize = i_size_read(sb->s_bdev->bd_inode) >> > > sb->s_blocksize_bits; > > if (*newLVSize == 0) > > pr_err("JFS: Cannot determine volume size\n"); > > @@ -549,7 +549,7 @@ static int jfs_fill_super(struct super_block *sb, void > > *data, int silent) > > goto out_unload; > > } > > inode->i_ino = 0; > > - inode->i_size = sb->s_bdev->bd_inode->i_size; > > + inode->i_size = i_size_read(sb->s_bdev->bd_inode); > > inode->i_mapping->a_ops = &jfs_metapage_aops; > > hlist_add_fake(&inode->i_hash); > > mapping_set_gfp_mask(inode->i_mapping, GFP_NOFS); > > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Jfs-discussion mailing list Jfs-discussion@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jfs-discussion