Morning, Just some quick remarks on XMLWriterNamespaceBase:
First, shouldn't incrementNesting() and decrementNesting() be protected instead of public? Second, perhaps the JavaDoc for defineNamespace() (and undefineNamespace() alike) would be clearer if it were "Report _to subclass_ that namespace has been defined." Third, I think it would make sense to declare the IXMLWriter methods that are implemented by XMLWriterNamespaceBase as "final" so subclasses cannot override them. If they really wanted to they could implement IXMLWriter on their own. And fourth, (in addition to what I just said above) it would be safer if reset() was final and delegated to e.g. an abstract resetInternal() for subclass cleanup. This way there would be less room for errors for subclass implementors that don't necessarily know that much of the framework code (like me... ;-)). Regards, Andreas ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ jibx-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/jibx-devs
