On 28/08/2015 18:05, Jim Laskey (Oracle) wrote:
https://bugs.openjdk.java.net/browse/JDK-8087181
<https://bugs.openjdk.java.net/browse/JDK-8087181>
http://cr.openjdk.java.net/~jlaskey/hs-rt/webrev-top
http://cr.openjdk.java.net/~jlaskey/hs-rt/webrev-jdk
http://cr.openjdk.java.net/~jlaskey/hs-rt/webrev-hotspot
Looks like the copyright headers on the files for the jdk will need to
be changed to the GPL + Classpath exception before this is pushed.
The other thing is that the indention for the .cpp/.hpp files needs to
follow the convention for the jdk repo, so 4 spaces rather than 2. There
are also a number of really long lines that would be good to fix up to
make it easier for future side-by-side reviews.
Is there is a reason for adding the ZIP_* functions to the the reorder-*
files, I don't think these files have been maintained for a number of years.
At a high-level I think this looks good. I hope to more detailed pass
on the jdk repo early next week.
-Alan.
