Hi, Jim. >> http://cr.openjdk.java.net/~jlaskey/8138960/webrev/index.html
These changes look good to me too. I assume that you'll be pushing this to verona/stage? Thanks, iris -----Original Message----- From: Mandy Chung Sent: Tuesday, October 06, 2015 7:26 AM To: Alan Bateman Cc: jigsaw-dev Subject: Re: RFR: JDK-8138960 - Module version is checked incorrectly in libjimage > On Oct 6, 2015, at 6:28 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > > On 06/10/2015 14:22, Jim Laskey (Oracle) wrote: >> Verona pit failing do to NEXT_VERSION +1 . libjimage code assumed that the >> module version would be constant until some later date. >> >> http://cr.openjdk.java.net/~jlaskey/8138960/webrev/index.html >> <http://cr.openjdk.java.net/~jlaskey/8138960/webrev/index.html> >> >> JDK-8138960 <https://bugs.openjdk.java.net/browse/JDK-8138960> >> >> Follow on changes at some later date coming with >> JDK-8138961 <https://bugs.openjdk.java.net/browse/JDK-8138961> Include >> version information in jimage locations >> JDK-8138962 <https://bugs.openjdk.java.net/browse/JDK-8138962> Use >> correct module version from hotspot when using jimage find resource > (Moving this to jigsaw-dev). > > This change looks okay, it means the version is ignored in JDK 9 main line, > which make sense. +1 We should check the version checking in jake and do the right checking (a separate issue). Mandy
