> On Feb 22, 2016, at 7:28 PM, Wang Weijun <weijun.w...@oracle.com> wrote: > > Webrev updated at http://cr.openjdk.java.net/~weijun/8130302/webrev.03/. > > -provider and loadProviderByName() are useless for jdk9/dev, and > loadProviderByClass() only uses reflection. >
I reviewed the provider loading part and looks good to me. > The SunPKCS11 compatibility line will be add in a sub-patch for jake. > You can send me the jake’s delta patch once you push the change to jdk9/dev. Thanks Mandy > --Max > > >> On Feb 23, 2016, at 10:25 AM, Wang Weijun <weijun.w...@oracle.com> wrote: >> >> >>>> >>>> You mean not supporting all pre-loaded providers in modules, but only one >>>> or two popular ones? >>>> >>> >>> I meant not support -providerClass for arbitrary providers loaded via >>> service loader. The only exception is SunPKCS11. In other words, >>> -providerClass can only be used to load legacy security provider via >>> Class::forName. >> >> Accepted. >> >>> >>> The man page should make it clear that -provider SunPKCS11 is recommended >>> instead of -providerClass sun.security.provider.SunPKCS11. It’s just an >>> alias to help migration. >> >> Yes. >> >> security-dev? I still see no comment from you. >> >> Thanks >> Max >> >>> >>> Mandy >>> >>>> Thanks >>>> Max >>>> >>>> >>>>> >>>>> Mandy >>>> >>> >> >
