On 03/02/2016 01:12 PM, Alan Bateman wrote:
On 02/03/2016 16:50, David M. Lloyd wrote:
Isn't there any way to break it up into functional sections or stages
that can be individually reviewed?
There source code is organized by module and there are also several
repositories, so I think it should be manageable without needing to do
fine grain slicing.
I am a bit more skeptical: I count a combined 2,928 files changed with
156,053 insertions and 51,363 deletions compared to the upstream
jdk9/jdk9 trees. With a single blob of that size, is it realistic to
expect that it can be reviewed sensibly?
Using the most recent data from my git mirror I get this approximate
breakdown (there are rounding errors in dirstat but this gives a good
general idea):
19.4% hotspot/
55.0% jdk/
20.0% langtools/
The JDK patch alone is going to be nearly 100,000 lines of insertions
and nearly 20,000 deletions. That's a pretty big patch.
--
- DML
